D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> ActionToolBarLayoutDetails.qml:126
> +
> +                    if (modelData.hasOwnProperty("displayHint") &&
> +                        modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide)) {

I think this can be simplified to

  return !modelData.hasOwnProperty("displayHint") || !modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide;

> ActionToolBarLayoutDetails.qml:180
> +                    }
> +                    if (modelData.hasOwnProperty("displayHint")
> +                        && modelData.displayHintSet(Kirigami.Action.DisplayHint.KeepVisible)) {

same here

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27653

To: ahiemstra, #kirigami
Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/0185f73d/attachment.html>