D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This applies a few fixes to ActionToolBar and PrivateActionToolButton when
  used in combination with QtQuick Controls 2's Action instead of 
  Kirigami.Action. It is a more elaborate version of D27638 <https://phabricator.kde.org/D27638> .
  
  - Properly check if PrivateActionToolButton should be visible
  - Use hasOwnProperty for checking property exists and write out everything
  - Don't try to use tooltip property that may not be defined

TEST PLAN
  Kirigami Gallery still shows actions correctly.
  A test QML with QQC2 actions shows them correct.
  
  (I have an autotest for ActionToolBar in the works that will include a
  tests with QQC2 Action)

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_action

REVISION DETAIL
  https://phabricator.kde.org/D27653

AFFECTED FILES
  src/controls/private/ActionToolBarLayoutDetails.qml
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/85a5af10/attachment.html>