D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

Benjamin Port noreply at phabricator.kde.org
Thu Feb 20 08:51:27 GMT 2020


bport accepted this revision.
bport added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> DeviceAutomounter.cpp:39
>  DeviceAutomounter::DeviceAutomounter(QObject *parent, const QVariantList &args)
> -    : KDEDModule(parent)
> +    : KDEDModule(parent), m_settings(new AutomounterSettings(this))
>  {

m_settings need to go to the next line

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27127

REVISION DETAIL
  https://phabricator.kde.org/D27480

To: meven, ervin, crossi, bport, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200220/7d4c3810/attachment.html>


More information about the Plasma-devel mailing list