D27505: Do not crash when icon's width or height is 0

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Weird. plasma-framework's version of icon (which this is copied from) has had that check for years.
  
  Would be good to dump this test qml somewhere in the repo. A folder full of tests which just have one component in a bunch of configurations.
  I've been pushing for that in p-f, and it catches so many things.

REPOSITORY
  R169 Kirigami

BRANCH
  icon_crash

REVISION DETAIL
  https://phabricator.kde.org/D27505

To: ahiemstra, #kirigami, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200219/91443d37/attachment-0001.html>