<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27505">View Revision</a></tr></table><br /><div><div><p>Weird. plasma-framework's version of icon (which this is copied from) has had that check for years.</p>
<p>Would be good to dump this test qml somewhere in the repo. A folder full of tests which just have one component in a bunch of configurations.<br />
I've been pushing for that in p-f, and it catches so many things.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>BRANCH</strong><div><div>icon_crash</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27505">https://phabricator.kde.org/D27505</a></div></div><br /><div><strong>To: </strong>ahiemstra, Kirigami, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart, hein<br /></div>