D27471: [plasma-session] Avoid potential race condition starting a service

David Edmundson noreply at phabricator.kde.org
Tue Feb 18 12:47:14 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in startup.cpp:429
> Could probably use an `m_service.isEmpty()` check since it will still needlessly do a `NameHasOwner` call

All usages of this class (which is just the 1 case to start ksmserver!) have a name passed.

Without a name it wouldn't ever finish.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27471

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200218/7eb7379a/attachment.html>


More information about the Plasma-devel mailing list