D27471: [plasma-session] Avoid potential race condition starting a service

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Feb 18 12:45:08 GMT 2020


broulik added inline comments.

INLINE COMMENTS

> startup.cpp:429
>  {
> +    if (QDBusConnection::sessionBus().interface()->isServiceRegistered(m_serviceId)) {
> +        qCDebug(PLASMA_SESSION) << m_process << "already running";

Could probably use an `m_service.isEmpty()` check since it will still needlessly do a `NameHasOwner` call

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27471

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200218/81820841/attachment-0001.html>


More information about the Plasma-devel mailing list