D27457: Move kcminit_startup and kded to plasma-session

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> fvogt wrote in startup.cpp:211
> This (and below) are started with an empty environment, which means that neither `DISPLAY`, `WAYLAND_DISPLAY` or `XAUTHORITY` are set. So everything breaks horribly, as seen by @lbeltrame and openQA.

StartProcessJob I think is fine. It's not set, so it'll inherit.

It's the extra arg to StartServiceJob that has potential to wipe the env.

It defaults to empty

and we do     p->setEnvironment(m_env);

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200218/45d8e1bb/attachment-0001.html>