D27457: Move kcminit_startup and kded to plasma-session

Fabian Vogt noreply at phabricator.kde.org
Tue Feb 18 08:37:48 GMT 2020


fvogt reopened this revision.
fvogt added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> startup.cpp:211
> +    const QVector<KJob*> sequence = {
> +        new StartProcessJob(QStringLiteral("kcminit_startup"), {}),
> +        new StartServiceJob(QStringLiteral("kded5"), {}, QStringLiteral("org.kde.kded"), QProcess::systemEnvironment() << QStringList{ QStringLiteral("KDED_STARTED_BY_KDEINIT=1") }),

This (and below) are started with an empty environment, which means that neither `DISPLAY`, `WAYLAND_DISPLAY` or `XAUTHORITY` are set. So everything breaks horribly, as seen by @lbeltrame and openQA.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200218/91dd33b2/attachment.html>


More information about the Plasma-devel mailing list