D27381: [sidebar] Resolve changes in module before switching

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  After some refactoring we close the module before checking if there are
  unsaved changes. We then try to resolve changes on the new KCM that
  we've just opened, which never has changes.
  
  BUG: 416834
  Fixed-in: 5.18.1

TEST PLAN
  Opened colours in systemsettings
  changed it
  switched to another kcm
  
  Did the same from within a search
  
  opened kinfocenter
  no prompts

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27381

AFFECTED FILES
  sidebar/SidebarMode.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200213/a15530b2/attachment.html>