<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />davidedmundson requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27381">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>After some refactoring we close the module before checking if there are<br />
unsaved changes. We then try to resolve changes on the new KCM that<br />
we've just opened, which never has changes.</p>
<p>BUG: 416834<br />
Fixed-in: 5.18.1</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Opened colours in systemsettings<br />
changed it<br />
switched to another kcm</p>
<p>Did the same from within a search</p>
<p>opened kinfocenter<br />
no prompts</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R124 System Settings</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27381">https://phabricator.kde.org/D27381</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>sidebar/SidebarMode.cpp</div></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>