D27085: [SystemTray] Bunch of fixes and improvements in QML

Konrad Materka noreply at phabricator.kde.org
Sat Feb 1 14:48:07 GMT 2020


kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  Few unrelated fixes, bunched togheter:
  
  - move some code from main.qml to PlasmoidItem where it belongs
  - easier to understand item size calculation
  - where possible, replace parent.parent comparitions with property
  - get rid of marginHints
  - Qt 5.14 compatibility fix in configuration
  - formatting etc

TEST PLAN
  Everything should work as before, this is just refactoring.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27085

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200201/d5e924a2/attachment-0001.html>


More information about the Plasma-devel mailing list