<table><tr><td style="">kmaterka created this revision.<br />kmaterka added reviewers: Plasma: Workspaces, Plasma.<br />kmaterka added a project: Plasma.<br />kmaterka requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27085">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Few unrelated fixes, bunched togheter:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">move some code from main.qml to PlasmoidItem where it belongs</li>
<li class="remarkup-list-item">easier to understand item size calculation</li>
<li class="remarkup-list-item">where possible, replace parent.parent comparitions with property</li>
<li class="remarkup-list-item">get rid of marginHints</li>
<li class="remarkup-list-item">Qt 5.14 compatibility fix in configuration</li>
<li class="remarkup-list-item">formatting etc</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>Everything should work as before, this is just refactoring.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27085">https://phabricator.kde.org/D27085</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/systemtray/package/contents/applet/CompactApplet.qml<br />
applets/systemtray/package/contents/ui/ConfigEntries.qml<br />
applets/systemtray/package/contents/ui/ExpandedRepresentation.qml<br />
applets/systemtray/package/contents/ui/HiddenItemsView.qml<br />
applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml<br />
applets/systemtray/package/contents/ui/items/AbstractItem.qml<br />
applets/systemtray/package/contents/ui/items/PlasmoidItem.qml<br />
applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml<br />
applets/systemtray/package/contents/ui/main.qml</div></div></div><br /><div><strong>To: </strong>kmaterka, Plasma: Workspaces, Plasma<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>