D29234: Fix various bugs introduced with heading

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> FullRepresentation.qml:454
>                                              elementId: "vertical-line"
> -                                            svg: lineSvg
> +                                            svg: PlasmaCore.Svg {
> +                                                id: lineSvg

Move the `Svg` somewhere outside the delegate, I don't want multiple instances of it

> NotificationItem.qml:125
>              id: notificationHeading
> -            anchors.fill: parent
> +            anchors.fill: notificationItem.inGroup ? undefined : parent
> +            Layout.fillWidth: true

Please use one of the `State` below for `inGroup` state

> NotificationItem.qml:139
> +
> +        MouseArea {
> +            anchors.fill: parent

This `MouseArea` should not be necessary and it makes the close button unusable

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200427/5e84bdc2/attachment-0001.html>