D29142: Add footer support to systray

Nathaniel Graham noreply at phabricator.kde.org
Fri Apr 24 19:06:16 BST 2020


ngraham added a comment.


  It also helps if your reviewer has applied the correct patch before he leaves a snarky comment. :)
  
  I can see now that this is working properly. But please to add more info into the Description and Test Plan sections so they can become a part of the historical record in the git log.

INLINE COMMENTS

> PlasmoidPopupsContainer.qml:38
>      property bool appletHasHeading: false
> -    property bool appletHeadingShown: appletHasHeading && activeApplet.fullRepresentationItem.header.visible
> -    property bool mergeHeadings: appletHasHeading && appletHeadingShown

Nothing was using this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29142

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200424/476553e1/attachment.html>


More information about the Plasma-devel mailing list