D29154: Use QWindow overload of QIcon::pixmap

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Apr 24 18:09:12 BST 2020


apol added a comment.


  In D29154#656516 <https://phabricator.kde.org/D29154#656516>, @cblack wrote:
  
  > Icon handling looks somewhat funky with this patch applied when a window changes DPI.
  >  F8257898: ksnip_20200424-111720.png <https://phabricator.kde.org/F8257898>
  
  
  Right, should re-render the pixmaps when the window changes (we do so in QtQuick).
  That said, I don't think that this is reason enough to keep this patch. I guess the alternative would be to render at the maximum dpi of all the outputs we have which is odd.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200424/70a981fa/attachment.html>


More information about the Plasma-devel mailing list