D29154: Use QWindow overload of QIcon::pixmap

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Apr 24 18:07:25 BST 2020


apol added a comment.


  +1
  
  I did the same thing for kirigami @ D29100 <https://phabricator.kde.org/D29100> and plasma-framework @ D29102 <https://phabricator.kde.org/D29102> yesterday after looking at Qt's code and assessing it was the right thing to do.
  I am not familiar with Breeze's code but the patch is sound.
  
  I do have all of the dpis so if you tell me how I'll test it.
  
  This should probably fix the BUG 418869.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200424/aa69cfba/attachment.html>


More information about the Plasma-devel mailing list