D29137: Added plasmoidHeading to clipboard and ported to Page

Niccolò Venerandi noreply at phabricator.kde.org
Thu Apr 23 20:09:52 BST 2020


niccolove added a comment.


  In D29137#655936 <https://phabricator.kde.org/D29137#655936>, @ngraham wrote:
  
  > Thanks! Implementation-wise, I would have re-arranged things a bit to have only one header for the `PC3.Page`, with the contents changing depending on the page in the stack, rather than your approach of giving each page in the stack its own header, but that works fine too and it's perfectly valid so I'll accept it.
  
  
  That was my first though, but the headings often use variables defined in their files which means that I should have brought everything to be one file or deal with passing variables though files. This felt cleaner and I guess it could scale better to new types of pages.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200423/e7028fb6/attachment.html>


More information about the Plasma-devel mailing list