D29057: Introduce PlaceholderMessage component

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> PlaceholderMessage.qml:10
> +import QtQuick.Layouts 1.13
> +import org.kde.kirigami 2.12
> +

as convention (sadly not used everywhere in the sources but at least in the "newer" files) use a namespace
import org.kde.kirigami 2.12 as Kirigami

> PlaceholderMessage.qml:107
> +     */
> +    property alias icon: icon.source
> +

for consistency with qqc2 icons it should be ActionIconGroup

> PlaceholderMessage.qml:130
> +     */
> +    property bool actionVisible: true
> +

remove this property.
then if a Kirigami.Action is used, that visible property can be used

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29057

To: ngraham, #vdg, #kirigami, mart
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200421/6985b982/attachment-0001.html>