D29057: Introduce PlaceholderMessage component

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> PlaceholderMessage.qml:20
> + *
> + * @code
> + * import org.kde.kirigami 2.11 as Kirigami

`@code{.qml}`

> PlaceholderMessage.qml:40
> + *
> + ** Used as a "here's how to proceed" message
> + * ListView {

Split into own codeblock

> PlaceholderMessage.qml:67
> + *
> + ** Used as a "there was a problem here" message
> + * Kirigami.Page {

Ditto

> PlaceholderMessage.qml:100
> +    /**
> +     * icon: string
> +     * The icon to show above the text label

This is a QVariant, not a string.

> PlaceholderMessage.qml:104
> +     * Optional; if undefined, the message will have no icon.
> +     *
> +     * @since 5.70

`@see Icon::source`

> PlaceholderMessage.qml:107
> +     */
> +    property alias icon: icon.source
> +

You probably want to add a property for the fallback icon as well

> PlaceholderMessage.qml:110
> +    /**
> +     * helperAction: QtQuickControls2 Action
> +     * An action that helps the user proceed. Typically used to guide the user

Not sure this will link properly.

> PlaceholderMessage.qml:141
> +
> +        visible: root.icon != undefined && root.icon.length > 0
> +        opacity: 0.5

Use `source` instead of an alias to it for better readability

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29057

To: ngraham, #vdg, #kirigami, mart
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200421/e1589d27/attachment.html>