D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style

Arjen Hiemstra noreply at phabricator.kde.org
Tue Apr 21 12:31:04 BST 2020


ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Use const ref for QColor and QJSValue values.
  Clean up code style, lots of missing braces and spaces.
  Don't use std::map if no lookup by key actually happens.
  std::vector is a much less heavy-weight container.

TEST PLAN
  Things still work.

REPOSITORY
  R169 Kirigami

BRANCH
  styling

REVISION DETAIL
  https://phabricator.kde.org/D29046

AFFECTED FILES
  src/colorutils.cpp
  src/colorutils.h

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200421/aabc780e/attachment.html>


More information about the Plasma-devel mailing list