D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre added a comment.


  In D28744#652854 <https://phabricator.kde.org/D28744#652854>, @ngraham wrote:
  
  > Yay. Almost there! I just see a few more things:
  >
  > 1. If I delete a whole item from the left-most list, there's no obvious way to get it back (what if I delete a system entry by accident?)
  
  
  I agree. Probably should do it like other kcms with pending deletion then.
  
  > 2. The Defaults button is present, but always disabled
  
  Hmm it works for me when changing shortcuts or changing defaults but the initial state is wrong probably because loading is now async. Will look into it.
  
  > 3. I see duplicate entries with different items inside them:
  
  These are not really duplicated but boil down to that the backend is represented correctly here. Some components have a different unique identifier  and happen to have the same user visible name. The old kcm merged them but I don't as I think most of these should be seperate because they  are related to different things.
  
  - The kded ones are not really duplicate but rather seperate. I think most of them are part of plasma(?) so I will see if I can change them to something more sensible (for example "Touchpad" or "Keyboard").
  - The powerdevil duplication  shouldn't even exist, @davidedmundson messed up while migrating the shortcuts but also fixed that. See D10668 <https://phabricator.kde.org/D10668>.
  - The run command one I have not seen but they also have different user visible names? How does the old kcm handle that?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200420/dd5c4a7b/attachment.html>