D28625: Use ShadowedRectangle for Card backgrounds

[Arjen Hiemstra]

ahiemstra added a comment.


  In D28625#652529 <https://phabricator.kde.org/D28625#652529>, @mart wrote:
  
  > In D28625#642954 <https://phabricator.kde.org/D28625#642954>, @cblack wrote:
  >
  > > Looks like a nice visual improvement.
  > >
  > > Are the changes to the scenegraph stuff related? They don't look like a related change to making the Kirigami.Card use the ShadowedRectangle to me.
  >
  >
  > they should be, as far i know, a fix for the 1 pixel border that had some blurriness.
  >  @ahiemstra can you confirm?
  
  
  They're both things I encountered while implementing this. One is a crash fix, the other is indeed a fix for pixel correctness.

INLINE COMMENTS

> mart wrote in AbstractCard.qml:31
> as we have a ColorUtils class now, since i've seen this super long thing just to make a color translucent many things, is maybe worth to have a ColorUtils.opacity(Kirigami.Theme.highlightColor, 0.3) instead?

This basically does the same thing as Kirigami.Separator. I think it'd be good to have this entire thing in ColorUtils yeah.

REPOSITORY
  R169 Kirigami

BRANCH
  card_shadowrect

REVISION DETAIL
  https://phabricator.kde.org/D28625

To: ahiemstra, #kirigami, #vdg, cblack, mart
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200420/16040a10/attachment.html>