D28625: Use ShadowedRectangle for Card backgrounds

Marco Martin noreply at phabricator.kde.org
Mon Apr 20 12:26:40 BST 2020


mart added inline comments.

INLINE COMMENTS

> AbstractCard.qml:31
> +        id: bg
> +        readonly property color pressedColor: Qt.tint(Kirigami.Theme.backgroundColor, Qt.rgba(
> +                                                        Kirigami.Theme.highlightColor.r,

as we have a ColorUtils class now, since i've seen this super long thing just to make a color translucent many things, is maybe worth to have a ColorUtils.opacity(Kirigami.Theme.highlightColor, 0.3) instead?

REPOSITORY
  R169 Kirigami

BRANCH
  card_shadowrect

REVISION DETAIL
  https://phabricator.kde.org/D28625

To: ahiemstra, #kirigami, #vdg, cblack
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200420/67102e7e/attachment.html>


More information about the Plasma-devel mailing list