D28904: Cleanup dependencies
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Apr 17 09:22:02 BST 2020
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
That unused `EditPage::openUrl` pulled in `KIOWidgets` with all its dependencies.
This includes `KCompletion` which implicitly made that `KComboBox` work.
Remove this and clean up the dependencies.
`NetworkManagerQt` seems to pull in `Qt::Network` but doesn't automatically find it.
TEST PLAN
- Still builds
- Battery crtical combo still works
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D28904
AFFECTED FILES
CMakeLists.txt
daemon/actions/bundled/CMakeLists.txt
kcmodule/global/CMakeLists.txt
kcmodule/global/generalPage.ui
kcmodule/profiles/CMakeLists.txt
kcmodule/profiles/EditPage.cpp
kcmodule/profiles/EditPage.h
To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200417/f86312d9/attachment-0001.html>
More information about the Plasma-devel
mailing list