<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28904">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>That unused <tt style="background: #ebebeb; font-size: 13px;">EditPage::openUrl</tt> pulled in <tt style="background: #ebebeb; font-size: 13px;">KIOWidgets</tt> with all its dependencies.<br />
This includes <tt style="background: #ebebeb; font-size: 13px;">KCompletion</tt> which implicitly made that <tt style="background: #ebebeb; font-size: 13px;">KComboBox</tt> work.<br />
Remove this and clean up the dependencies.<br />
<tt style="background: #ebebeb; font-size: 13px;">NetworkManagerQt</tt> seems to pull in <tt style="background: #ebebeb; font-size: 13px;">Qt::Network</tt> but doesn't automatically find it.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Still builds</li>
<li class="remarkup-list-item">Battery crtical combo still works</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28904">https://phabricator.kde.org/D28904</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
daemon/actions/bundled/CMakeLists.txt<br />
kcmodule/global/CMakeLists.txt<br />
kcmodule/global/generalPage.ui<br />
kcmodule/profiles/CMakeLists.txt<br />
kcmodule/profiles/EditPage.cpp<br />
kcmodule/profiles/EditPage.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>