D26934: KCM/Autostart Add a model to separate logic from UI

Méven Car noreply at phabricator.kde.org
Wed Apr 15 14:51:07 BST 2020


meven added inline comments.

INLINE COMMENTS

> ervin wrote in autostartmodel.h:52
> Weeell... knowing about Qt::DisplayRole is kind of prerequisite to making your own model. :-)

As you want.
IMO this is not a good pattern to expect reviewers to have any previous knowledge about enum values, especially for new contributors (I was concerned by this when I started reading QAbstractModel implementations)
Better to teach them those values by making things explicit. It also helps when using an IDE for discoverability.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26934

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200415/96df56e1/attachment-0001.html>


More information about the Plasma-devel mailing list