D28817: fix (kcm): correct output identifier position on wayland

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Thanks. Some minor remaining nitpicks you can change on push.

INLINE COMMENTS

> output_identifier.cpp:28
> +#include <PlasmaQuick/Dialog>
> +#include <KDeclarative/kdeclarative/qmlobject.h>
>  

Lexicographical order. Also add an empty line to differentiate include groups:

  #include <QStandardPaths>
  #include <QTimer>
  #include <QQuickItem>
  #include <QQuickView>
  
  #include <KDeclarative/kdeclarative/qmlobject.h>
  #include <PlasmaQuick/Dialog>

> output_identifier.cpp:72
>          if (config->supportedFeatures() & KScreen::Config::Feature::PerOutputScaling) {
> -            // no scale adjustment needed on Wayland
> -            logicalSize = deviceSize;
> +            // Scale adjustment is not needed on Wayland, we use logical size"
> +            logicalSize = output->logicalSize().toSize();

You wanted to add a `.` but it became a `"`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200414/a39f2220/attachment-0001.html>