<table><tr><td style="">romangg accepted this revision.<br />romangg added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28817">View Revision</a></tr></table><br /><div><div><p>Thanks. Some minor remaining nitpicks you can change on push.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28817#inline-164342">View Inline</a><span style="color: #4b4d51; font-weight: bold;">output_identifier.cpp:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> <span class="cpf"><PlasmaQuick/Dialog></span><span style="color: #304a96"></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> <span class="cpf"><KDeclarative/kdeclarative/qmlobject.h></span><span style="color: #304a96"></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Lexicographical order. Also add an empty line to differentiate include groups:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#include <QStandardPaths>
#include <QTimer>
#include <QQuickItem>
#include <QQuickView>

#include <KDeclarative/kdeclarative/qmlobject.h>
#include <PlasmaQuick/Dialog></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28817#inline-164341">View Inline</a><span style="color: #4b4d51; font-weight: bold;">output_identifier.cpp:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">config</span><span style="color: #aa2211">-></span><span class="n">supportedFeatures</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span class="n">KScreen</span><span style="color: #aa2211">::</span><span class="n">Config</span><span style="color: #aa2211">::</span><span class="n">Feature</span><span style="color: #aa2211">::</span><span class="n">PerOutputScaling</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #74777d">// <span class="bright">no s</span>cale adjustment needed on Wayland</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">logicalSize</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">device</span>Size</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #74777d">// <span class="bright">S</span>cale adjustment <span class="bright">is not </span>needed on Wayland<span class="bright">, we use logical size"</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">logicalSize</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">output</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">logicalSize</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">to</span>Size<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span>;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You wanted to add a <tt style="background: #ebebeb; font-size: 13px;">.</tt> but it became a <tt style="background: #ebebeb; font-size: 13px;">"</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28817">https://phabricator.kde.org/D28817</a></div></div><br /><div><strong>To: </strong>bport, Plasma, romangg, davidedmundson<br /><strong>Cc: </strong>romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>