D28818: fix(kcm): Identify output according to current applied position, not an unapplied position

[Roman Gilg]

romangg added a comment.


  Header subject and commit message body must have shorter line length in line with message guideline. Also note regarding capitalization Angular's subject guideline <https://github.com/angular/angular/blob/3cf2005a936bec2058610b0786dd0671dae3d358/CONTRIBUTING.md#subject>.
  
  Also the current description sucks. That's a single sentence with way too many words and no grammar.
  
  Come on, coding is not only about the code. Be proud of your work and present it to us in the way that it deserves.
  
  Also my assumption is you work together with the original reviewers in the same company and may have discussed this patch internally already. That's fine but note that this project and any other KDE project is not owned by your company alone and it's your responsibility in the end to transform your internal discussions and the knowledge you gained from that into public knowledge available to all members of this community.
  
  That's why a good description, and in the end all of the documentation you do when coding, is tremendously important.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

To: bport, #plasma, romangg
Cc: romangg, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200414/e6e09703/attachment-0001.html>