D28725: Drop QWindow and explicit devicePixelRatio usage for ComboBox

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> breezestyle.cpp:4474
>                      painter->fillRect(iconRect, option->palette.brush(QPalette::Base));
>                  proxy()->drawItemPixmap(painter, iconRect, Qt::AlignCenter, pixmap);
>  

QPixmap Helper::coloredIcon(const QIcon& icon,  const QPalette& palette, const QSize &size, QIcon::Mode mode, QIcon::State state)
  ...
          const QPixmap pixmap = icon.pixmap(size, mode, state);

this takes a logical size, so this is indeed wrong.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28725

To: broulik, #plasma, davidre, hpereiradacosta, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200410/178d202a/attachment.html>