<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28725">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28725#inline-163661">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezestyle.cpp:4474</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                    <span class="n">painter</span><span style="color: #aa2211">-></span><span class="n">fillRect</span><span class="p">(</span><span class="n">iconRect</span><span class="p">,</span> <span class="n">option</span><span style="color: #aa2211">-></span><span class="n">palette</span><span class="p">.</span><span class="n">brush</span><span class="p">(</span><span class="n">QPalette</span><span style="color: #aa2211">::</span><span class="n">Base</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">proxy</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">drawItemPixmap</span><span class="p">(</span><span class="n">painter</span><span class="p">,</span> <span class="n">iconRect</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">AlignCenter</span><span class="p">,</span> <span class="n">pixmap</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">    QPixmap Helper::coloredIcon(const QIcon& icon,  const QPalette& palette, const QSize &size, QIcon::Mode mode, QIcon::State state)
...
        const QPixmap pixmap = icon.pixmap(size, mode, state);</pre></div>

<p style="padding: 0; margin: 8px;">this takes a logical size, so this is indeed wrong.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28725">https://phabricator.kde.org/D28725</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidre, hpereiradacosta, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>