D28730: Couple of 'trivial' fixes for broken code
Johan Ouwerkerk
noreply at phabricator.kde.org
Fri Apr 10 21:04:53 BST 2020
ouwerkerk created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.
REVISION SUMMARY
Issues were found by running code with QT_QUICK_CONTROLS_MOBILE=1
- `Units` does not exist in SwipeListItem due to how Kirigami is imported
- ActionButton (private) is trying to call `hasOwnProperty()` on `null`
REPOSITORY
R169 Kirigami
BRANCH
fixes-for-qt_quick_controls_mobile
REVISION DETAIL
https://phabricator.kde.org/D28730
AFFECTED FILES
src/controls/private/ActionButton.qml
src/controls/templates/SwipeListItem.qml
To: ouwerkerk
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200410/e0598536/attachment.html>
More information about the Plasma-devel
mailing list