<table><tr><td style="">ouwerkerk created this revision.<br />Herald added a project: Kirigami.<br />Herald added a subscriber: plasma-devel.<br />ouwerkerk requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28730">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Issues were found by running code with QT_QUICK_CONTROLS_MOBILE=1</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">Units</tt> does not exist in SwipeListItem due to how Kirigami is imported</li>
<li class="remarkup-list-item">ActionButton (private) is trying to call <tt style="background: #ebebeb; font-size: 13px;">hasOwnProperty()</tt> on <tt style="background: #ebebeb; font-size: 13px;">null</tt></li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>BRANCH</strong><div><div>fixes-for-qt_quick_controls_mobile</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28730">https://phabricator.kde.org/D28730</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/controls/private/ActionButton.qml<br />
src/controls/templates/SwipeListItem.qml</div></div></div><br /><div><strong>To: </strong>ouwerkerk<br /><strong>Cc: </strong>plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart<br /></div>