D28713: Return buffer to pipewire when returning early from recordFrame

Carson Black noreply at phabricator.kde.org
Fri Apr 10 00:10:32 BST 2020


cblack created this revision.
cblack added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Even when something goes wrong, the buffer should be returned to pipewire for recycling on next frame.

TEST PLAN
  Before: when something goes wrong when screencasting, first errors are the actual issue and subsequent errors are due to pipewire not having any buffers for the pw_stream_deque_buffer call
  After: when something goes wrong when screencasting, errors are always the actual issue

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  cblack/screencaststream-return-buffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28713

AFFECTED FILES
  src/screencaststream.cpp

To: cblack, #plasma, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200409/d007487a/attachment.html>


More information about the Plasma-devel mailing list