<table><tr><td style="">cblack created this revision.<br />cblack added reviewers: Plasma, jgrulich.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />cblack requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28713">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Even when something goes wrong, the buffer should be returned to pipewire for recycling on next frame.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Before: when something goes wrong when screencasting, first errors are the actual issue and subsequent errors are due to pipewire not having any buffers for the pw_stream_deque_buffer call<br />
After: when something goes wrong when screencasting, errors are always the actual issue</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R838 Flatpak Support: KDE Portal for XDG Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>cblack/screencaststream-return-buffers (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28713">https://phabricator.kde.org/D28713</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/screencaststream.cpp</div></div></div><br /><div><strong>To: </strong>cblack, Plasma, jgrulich<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>