D28664: [OverlaySheet] add bottomMargin property

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch, but why would you need the bottom margin to be customizable? Shouldn't the default be to simply center the sheet vertically when it's not as tall as the window, as (IIRC) it was before?

INLINE COMMENTS

> OverlaySheet.qml:108
> +     */
> +    property real bottomMargin: Units.gridUnit*2 
> +

missing whitespace around the times sign

> OverlaySheet.qml:280
>                  from: -outerFlickable.height
> -                to: Math.max(0, outerFlickable.height - outerFlickable.contentHeight + headerItem.height + footerItem.height)
> +                to: Math.max(0, outerFlickable.height - outerFlickable.contentHeight + headerItem.height + footerItem.height)+root.bottomMargin
>                  duration: Units.longDuration

missing whitespace around the plus sign

> OverlaySheet.qml:300
>                  ? Math.max(0, outerFlickable.height - outerFlickable.contentHeight + headerItem.height + footerItem.height)
> -                : outerFlickable.contentHeight - outerFlickable.height + outerFlickable.topEmptyArea + headerItem.height + footerItem.height
> +                : outerFlickable.contentHeight - outerFlickable.height + outerFlickable.topEmptyArea + headerItem.height + footerItem.height)+root.bottomMargin
>              duration: Units.longDuration

ditto

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28664

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200407/d3af9ac4/attachment-0001.html>