<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28664">View Revision</a></tr></table><br /><div><div><p>Thanks for the patch, but why would you need the bottom margin to be customizable? Shouldn't the default be to simply center the sheet vertically when it's not as tall as the window, as (IIRC) it was before?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28664#inline-163265">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OverlaySheet.qml:108</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">property</span> <span style="color: #004012">real</span> <span style="color: #aa4000">bottomMargin:</span> <span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">gridUnit</span><span style="color: #aa2211">*</span><span style="color: #601200">2</span> 
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">missing whitespace around the times sign</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28664#inline-163263">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OverlaySheet.qml:280</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">from:</span> <span style="color: #aa2211">-</span><span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">height</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #aa4000">to:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">-</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">contentHeight</span> <span style="color: #aa2211">+</span> <span style="color: #004012">headerItem</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">footerItem</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">to:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">-</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">contentHeight</span> <span style="color: #aa2211">+</span> <span style="color: #004012">headerItem</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">footerItem</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">root</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">bottomMargin</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">duration:</span> <span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">longDuration</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">missing whitespace around the plus sign</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28664#inline-163264">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OverlaySheet.qml:300</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa2211">?</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">-</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">contentHeight</span> <span style="color: #aa2211">+</span> <span style="color: #004012">headerItem</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">footerItem</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #aa2211">:</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">contentHeight</span> <span style="color: #aa2211">-</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">topEmptyArea</span> <span style="color: #aa2211">+</span> <span style="color: #004012">headerItem</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">footerItem</span><span class="p">.</span><span style="color: #004012">height</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa2211">:</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">contentHeight</span> <span style="color: #aa2211">-</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">outerFlickable</span><span class="p">.</span><span style="color: #004012">topEmptyArea</span> <span style="color: #aa2211">+</span> <span style="color: #004012">headerItem</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">footerItem</span><span class="p">.</span><span style="color: #004012">height<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">root</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">bottomMargin</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">duration:</span> <span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">longDuration</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28664">https://phabricator.kde.org/D28664</a></div></div><br /><div><strong>To: </strong>cblack, Kirigami<br /><strong>Cc: </strong>ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart<br /></div>