D28214: Add background portal

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> background.cpp:69
> +    qCDebug(XdgDesktopPortalKdeBackground) << "GetAppState called: no parameters";
> +    return m_appStates;
> +}

I don't really understand why we're exposing this. Is it for contained apps?

> background.cpp:133
> +
> +        QVariantMap map;
> +        map.insert(QStringLiteral("result"), static_cast<uint>(result));

const QVariantMap map = { {QStringLiteral("result"), static_cast<uint>(result)} };

> background.cpp:194
> +    if (autostartFlags.testFlag(AutostartFlag::Activatable)) {
> +       desktopEntryConfigGroup.writeEntry(QStringLiteral("DBusActivatable"), true);
> +    }

Will dbus look in autostart though?

> background.cpp:207
> +
> +    connect(window, &KWayland::Client::PlasmaWindow::activeChanged, this, [=] () {
> +        setActiveWindow(window->appId(), window->isActive());

context should be [this]

> background.cpp:210
> +    });
> +    connect(window, &KWayland::Client::PlasmaWindow::unmapped, this, [=] () {
> +        uint windows = 0;

[this]

> background.h:79
> +    uint m_notificationCounter = 0;
> +    QList<KWayland::Client::PlasmaWindow*> m_windowList;
> +    QVariantMap m_appStates;

I'd call it windows, it's better not include the type. It will change to QVector with Qt6 anyway.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28214

To: jgrulich, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200406/e7bfd5e1/attachment-0001.html>