D28512: Port Konsole and Kate runners and dataengine away from KToolInvocation

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Apr 2 13:02:24 BST 2020


broulik created this revision.
broulik added reviewers: Plasma, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead use `CommandLauncherJob`.
  Also set `desktopFileName` for nicer startup feedback

TEST PLAN
  - Can launch kate sessions from krunner
  - Can launch konsole sessions from krunner
  - Can launch konsole sessions from konsole sessions plasmoid
  
  I kinda feel `CommandLauncherJob` should have a `QString executable, QStringList args` constructor so I don't have to escape things myself?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28512

AFFECTED FILES
  dataengines/konsoleprofiles/CMakeLists.txt
  dataengines/konsoleprofiles/konsoleprofilesservice.cpp
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200402/35cf4c5b/attachment.html>


More information about the Plasma-devel mailing list