<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, dfaure.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28512">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Instead use <tt style="background: #ebebeb; font-size: 13px;">CommandLauncherJob</tt>.<br />
Also set <tt style="background: #ebebeb; font-size: 13px;">desktopFileName</tt> for nicer startup feedback</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Can launch kate sessions from krunner</li>
<li class="remarkup-list-item">Can launch konsole sessions from krunner</li>
<li class="remarkup-list-item">Can launch konsole sessions from konsole sessions plasmoid</li>
</ul>

<p>I kinda feel <tt style="background: #ebebeb; font-size: 13px;">CommandLauncherJob</tt> should have a <tt style="background: #ebebeb; font-size: 13px;">QString executable, QStringList args</tt> constructor so I don't have to escape things myself?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28512">https://phabricator.kde.org/D28512</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>dataengines/konsoleprofiles/CMakeLists.txt<br />
dataengines/konsoleprofiles/konsoleprofilesservice.cpp<br />
runners/katesessions/CMakeLists.txt<br />
runners/katesessions/katesessions.cpp<br />
runners/konsoleprofiles/CMakeLists.txt<br />
runners/konsoleprofiles/konsoleprofiles.cpp</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, dfaure<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>