D27100: [GTK Config] Parameterise GTK config editing

[Carson Black]

cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  Besides one minor over-verbosity issue, this looks like shipit material to me. Drop the QVariant() wrappers (but don't drop the `#include`) before landing, please.

INLINE COMMENTS

> gtktheme.cpp:42
>      ) {
> -        ConfigEditor::setGtk2ConfigValue(QStringLiteral("gtk-theme-name"), QStringLiteral("Breeze"));
> +        ConfigEditor::setGtk2ConfigValue(QStringLiteral("gtk-theme-name"), QVariant(QStringLiteral("Breeze")));
>      }

You don't need to wrap the QStringLiteral with a QVariant here

> gtktheme.cpp:53-55
> +        ConfigEditor::setGtk3ConfigValueGSettings(QStringLiteral("gtk-theme"), QVariant(QStringLiteral("Breeze")));
> +        ConfigEditor::setGtk3ConfigValueSettingsIni(QStringLiteral("gtk-theme-name"), QVariant(QStringLiteral("Breeze")));
> +        ConfigEditor::setGtk3ConfigValueXSettingsd(QStringLiteral("Net/ThemeName"), QVariant(QStringLiteral("Breeze")));

Ditto here

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200401/a47a1fdd/attachment-0001.html>