<table><tr><td style="">cblack accepted this revision.<br />cblack added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27100">View Revision</a></tr></table><br /><div><div><p>Besides one minor over-verbosity issue, this looks like shipit material to me. Drop the QVariant() wrappers (but don't drop the <tt style="background: #ebebeb; font-size: 13px;">#include</tt>) before landing, please.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27100#inline-162211">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gtktheme.cpp:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">ConfigEditor</span><span style="color: #aa2211">::</span><span class="n">setGtk2ConfigValue</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"gtk-theme-name"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Breeze"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">ConfigEditor</span><span style="color: #aa2211">::</span><span class="n">setGtk2ConfigValue</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"gtk-theme-name"</span><span class="p">),</span> <span class="n">Q<span class="bright">Variant</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">Q</span>StringLiteral</span><span class="p">(</span><span style="color: #766510">"Breeze"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You don't need to wrap the QStringLiteral with a QVariant here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27100#inline-162212">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gtktheme.cpp:53-55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">ConfigEditor</span><span style="color: #aa2211">::</span><span class="n">setGtk3ConfigValue<span class="bright">Dconf</span></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"gtk-theme"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Breeze"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">ConfigEditor</span><span style="color: #aa2211">::</span><span class="n">setGtk3ConfigValueSettingsIni</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"gtk-theme-name"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Breeze"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">ConfigEditor</span><span style="color: #aa2211">::</span><span class="n">setGtk3ConfigValueXSettingsd</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Net/ThemeName"</span><span class="p">),</span> <span class="bright"> </span><span class="n"><span class="bright">Q</span>StringLiteral</span><span class="p">(</span><span style="color: #766510">"Breeze"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">ConfigEditor</span><span style="color: #aa2211">::</span><span class="n">setGtk3ConfigValue<span class="bright">GSettings</span></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"gtk-theme"</span><span class="p">),</span> <span class="n">Q<span class="bright">Variant</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">Q</span>StringLiteral</span><span class="p">(</span><span style="color: #766510">"Breeze"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">ConfigEditor</span><span style="color: #aa2211">::</span><span class="n">setGtk3ConfigValueSettingsIni</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"gtk-theme-name"</span><span class="p">),</span> <span class="n">Q<span class="bright">Variant</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">Q</span>StringLiteral</span><span class="p">(</span><span style="color: #766510">"Breeze"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">ConfigEditor</span><span style="color: #aa2211">::</span><span class="n">setGtk3ConfigValueXSettingsd</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Net/ThemeName"</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">QVariant</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">Q</span>StringLiteral</span><span class="p">(</span><span style="color: #766510">"Breeze"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ditto here</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R99 KDE Gtk Configuration Tool</div></div></div><br /><div><strong>BRANCH</strong><div><div>parameterise-gtk-config-io (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27100">https://phabricator.kde.org/D27100</a></div></div><br /><div><strong>To: </strong>gikari, Plasma, cblack<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>