D13243: Add checkbox that can show virtual streams in the applet.

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigGeneral.qml:89
> +
> +    QQC2.CheckBox {
> +        id: showRealDevicesOnly

This isn't a feedback-related item so it shouldn't be in the Feedback section. I would do it more like this:

  Item {
      Kirigami.FormData.isSection: true
  }
  
  QQC2.CheckBox {
      id: showRealDevicesOnly
      Kirigami.FormData.label: i18n("Show:")
      text: i18n("Virtual audio streams and devices")
  }

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190927/528f444b/attachment.html>