D24203: Add settings change listener
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Sep 24 20:43:07 BST 2019
broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
I found it's on `chrome.storage` and not `chrome.storage.sync`. This also works with Firefox now.
Also removes the need to have the options page explicitly send a signal that settings changed.
TEST PLAN
- Changed some settings, had them sent to the host just fine. Both on Firefox 69 and Chrome 77
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D24203
AFFECTED FILES
extension/extension.js
extension/options.js
extension/utils.js
To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190924/b7b1ac46/attachment.html>
More information about the Plasma-devel
mailing list