D24178: Add ability to cycle through sources in mediacontroller applet

[Nathaniel Graham]

ngraham added reviewers: broulik, Plasma.
ngraham added a comment.


  +1 for the desired end goal, but I have some implementation concerns:

INLINE COMMENTS

> ExpandedRepresentation.qml:121
>                  seekSlider.moved();
> +            } else if (event.key === Qt.Key_W) {
> +                root.action_walk_through()

Why [W]? W for Walk? Seems kind of arbitrary; "walk" isn't really a word I would associate with this. In any event this seems like the kind of thing that would benefit from being a global shortcut rather than something that only works when the applet is open and has focus.

> main.qml:252
> +    function action_walk_through() {
> +        if (mpris2Source.sources.length < 3) {
> +            return

Why wouldn't you want to be able to do this when there are two sources?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24178

To: dylanmcdougall, broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190924/bfad0399/attachment.html>