D5961: PoC: Generic adoption of KUserFeedback for Discover

[Nathaniel Graham]

ngraham added a comment.


  This doesn't build for me:
  
    [ 82%] Building CXX object discover/CMakeFiles/plasma-discover.dir/plasmauserfeedback.cpp.o
    In file included from /home/nate/kde/build/discover/discover/plasmauserfeedback.cpp:4:
    /home/nate/kde/build/discover/discover/plasmauserfeedback.h:6:10: fatal error: KUserFeedback/Provider: No such file or directory
        6 | #include <KUserFeedback/Provider>
          |          ^~~~~~~~~~~~~~~~~~~~~~~~
    compilation terminated.
  
  I have the latest KUserFeedback and the KCM listed as a dependency installed.
  
  Also...
  
  > Creates components so it can be integrated in any Kirigami application though.
  
  Shouldn't these be in Kirigami, then?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190917/0354da69/attachment-0001.html>