D24011: Provide a telemetrics kcm module for Plasma

David Edmundson noreply at phabricator.kde.org
Tue Sep 17 12:48:33 BST 2019


davidedmundson added a comment.


  Probably could do with a screenshot as I expect this will need quite thorough UI iterations to get the wording spot on.

INLINE COMMENTS

> feedback.cpp:16
> +    , m_globalConfig(KSharedConfig::openConfig(QStringLiteral("KDE/UserFeedback.conf"), KConfig::NoGlobals))
> +    , m_plasmaConfig(KSharedConfig::openConfig(QStringLiteral("PlasmaUserFeedback")))
> +{

Is including kdeglobals here deliberate?

KUserFeedback won't read it..but maybe it makes sense?

> feedback.cpp:22
> +    // the KCM will respect that and not write the value enabling kuserfeedback
> +    // Note this will need some work as by default KUserFeedback assumes IsEnabled=false
> +

Did I write that line? I genuinely can't remember :/

In any case, this should work for having a syadmin force disable telemetrics by kiosk which I thought was the most likely case.

It doesn't cover the sysadmin force enabling it - but that probably isn't too useful if we don't have a configurable server anyway

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24011

To: apol, #plasma, vkrause
Cc: davidedmundson, ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190917/39d04a91/attachment.html>


More information about the Plasma-devel mailing list