D23151: Implement Web Share API through Purpose

[Carl Schwan]

ognarb added a comment.


  I will try to find time to test it today

INLINE COMMENTS

> content-script.js:24
> +    return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function(c) {
> +        var r = Math.random()*16|0, v = c == 'x' ? r : (r&0x3|0x8);
> +        return v.toString(16);

var -> const

> content-script.js:148
>  
> -// we give our transfer div a "random id" for privacy
> -// from https://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript
> -var mediaSessionsTransferDivId ='xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function(c) {
> -    var r = Math.random()*16|0, v = c == 'x' ? r : (r&0x3|0x8);
> -    return v.toString(16);
> -});
> +var mediaSessionsTransferDivId = generateGuid();
>  

var -> let

> content-script.js:852
> +//
> +var purposeTransferDivId = generateGuid();
> +var purposeTransferClassName = "p" + purposeTransferDivId.replace(/-/g, "");

var -> let

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/45c4a1d2/attachment.html>