<table><tr><td style="">ognarb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23151">View Revision</a></tr></table><br /><div><div><p>I will try to find time to test it today</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23151#inline-135725">View Inline</a><span style="color: #4b4d51; font-weight: bold;">content-script.js:24</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span style="color: #766510">'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'</span><span class="p">.</span><span style="color: #004012">replace</span><span class="p">(</span><span style="color: #bb6688">/[xy]/g</span><span class="p">,</span> <span style="color: #aa4000">function</span><span class="p">(</span><span style="color: #004012">c</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">var</span> <span style="color: #004012">r</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">random</span><span class="p">()</span><span style="color: #aa2211">*</span><span style="color: #601200">16</span><span style="color: #aa2211">|</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">v</span> <span style="color: #aa2211">=</span> <span style="color: #004012">c</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'x'</span> <span style="color: #aa2211">?</span> <span style="color: #004012">r</span> <span style="color: #aa2211">:</span> <span class="p">(</span><span style="color: #004012">r</span><span style="color: #aa2211">&</span><span style="color: #601200">0x3</span><span style="color: #aa2211">|</span><span style="color: #601200">0x8</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span style="color: #004012">v</span><span class="p">.</span><span style="color: #004012">toString</span><span class="p">(</span><span style="color: #601200">16</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">var -> const</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23151#inline-135726">View Inline</a><span style="color: #4b4d51; font-weight: bold;">content-script.js:148</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #74777d"><span class="bright">// we give our t</span>ransfer<span class="bright"> div a "random id" for privacy</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d">// from https://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">var</span> <span style="color: #004012">mediaSessionsTransferDivId</span> <span style="color: #aa2211">=</span><span style="color: #766510">'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'</span><span class="p">.</span><span style="color: #004012">replace</span><span class="p">(</span><span style="color: #bb6688">/[xy]/g</span><span class="p">,</span> <span style="color: #aa4000">function</span><span class="p">(</span><span style="color: #004012">c</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">var</span> <span style="color: #004012">r</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">random</span><span class="p">()</span><span style="color: #aa2211">*</span><span style="color: #601200">16</span><span style="color: #aa2211">|</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">v</span> <span style="color: #aa2211">=</span> <span style="color: #004012">c</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'x'</span> <span style="color: #aa2211">?</span> <span style="color: #004012">r</span> <span style="color: #aa2211">:</span> <span class="p">(</span><span style="color: #004012">r</span><span style="color: #aa2211">&</span><span style="color: #601200">0x3</span><span style="color: #aa2211">|</span><span style="color: #601200">0x8</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span style="color: #004012">v</span><span class="p">.</span><span style="color: #004012">toString</span><span class="p">(</span><span style="color: #601200">16</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #aa4000"><span class="bright">var</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">mediaSessionsT</span>ransfer<span class="bright">DivId</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">generateGuid</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">var -> let</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23151#inline-135724">View Inline</a><span style="color: #4b4d51; font-weight: bold;">content-script.js:852</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">//</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">var</span> <span style="color: #004012">purposeTransferDivId</span> <span style="color: #aa2211">=</span> <span style="color: #004012">generateGuid</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">var</span> <span style="color: #004012">purposeTransferClassName</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"p"</span> <span style="color: #aa2211">+</span> <span style="color: #004012">purposeTransferDivId</span><span class="p">.</span><span style="color: #004012">replace</span><span class="p">(</span><span style="color: #bb6688">/-/g</span><span class="p">,</span> <span style="color: #766510">""</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">var -> let</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23151">https://phabricator.kde.org/D23151</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, fvogt, davidedmundson, nicolasfella, apol, ognarb<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>